Skip to content

Commit ab0dc64

Browse files
committed
Add comment regarding the revert
1 parent dc53e4a commit ab0dc64

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

refresh.template.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -786,7 +786,9 @@ def get_workspace_root(path_from_execroot: pathlib.PurePath):
786786

787787
# We run the emcc process with the environment variable EM_COMPILER_WRAPPER to intercept the command line arguments passed to `clang`.
788788
emcc_process = subprocess.run(
789-
[emcc_driver] + compile_args[1:],
789+
# On windows, it fails to spawn the subprocess when the path uses forward slashes as a separator.
790+
# Here, we convert emcc driver path to use the native path separator.
791+
[str(emcc_driver)] + compile_args[1:],
790792
# MIN_PY=3.7: Replace PIPEs with capture_output.
791793
stdout=subprocess.PIPE,
792794
stderr=subprocess.PIPE,

0 commit comments

Comments
 (0)