Fix: exception when external link exists under windows and runfiles enabled #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤦🏻 This is my bug flipping things over to pathlib. Thanks so much for noticing and taking the time to fix. Made a small tweak to compact things, since current_dest is already a pathlib.Path, and am merging. Please lmk if you have any further problems or if I've messed something up. Thanks again for leaving things better than you found them :) Happy coding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have observed an exception when using compile commands under windows with runfiles enabled.
The error is, that a windows path object has no method removeprefix.
Steps to reproduce:
Options in .bazelrc
build --enable_runfiles
startup --windows_enable_symlinks