Skip to content

Add Callout for PreferWriteOnlyAttribute() validators in GoDoc comments #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Mar 1, 2025

Adds a callout for PreferWriteOnlyAttribute() validators usage about the persistent nature of the warnings for practitioners.

@SBGoods SBGoods requested a review from a team as a code owner March 1, 2025 00:40
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think we necessarily need to retroactively remove that changelog entry, but I don't think it'll cause any issues either 👍🏻

@austinvalle austinvalle merged commit 88ce093 into main Mar 3, 2025
5 checks passed
@austinvalle austinvalle deleted the SBGoods/preferwriteonly-warning branch March 3, 2025 14:16
@austinvalle austinvalle added this to the v0.18.0 milestone Mar 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants