Skip to content

New package dynamicvalidator #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

magodo
Copy link
Contributor

@magodo magodo commented Nov 24, 2024

This PR adds a new package dynamicvalidator to support cross attribute validations.

@magodo magodo requested a review from a team as a code owner November 24, 2024 00:04
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this package bootstrapped @magodo 🙌🏻 , just a couple suggestions to fix the compilable examples.

We also will need a changelog if you'd like to generate that and push it to your branch.

@magodo
Copy link
Contributor Author

magodo commented Dec 6, 2024

@austinvalle Thank you! I've updated the code accordingly, please take another look!

austinvalle
austinvalle previously approved these changes Dec 12, 2024
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @magodo! I'm going to push a changelog to your branch + remove one of the comments the example, then will merge + release this.

@austinvalle austinvalle added the enhancement New feature or request label Dec 12, 2024
@austinvalle austinvalle added this to the v0.16.0 milestone Dec 12, 2024
@austinvalle austinvalle merged commit 16687f3 into hashicorp:main Dec 12, 2024
6 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants