Skip to content

Support generic SQLAlchemy Array type #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2019
Merged

Support generic SQLAlchemy Array type #246

merged 1 commit into from
Sep 9, 2019

Conversation

Forever-Young
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 6, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 97.328% when pulling 4d8db8e on Forever-Young:master into 5eb5559 on graphql-python:master.

@jnak
Copy link
Collaborator

jnak commented Sep 7, 2019

Thanks for sending a PR. There is a linter error that prevents me from accepting this.
See https://travis-ci.org/graphql-python/graphene-sqlalchemy/jobs/581544423#L272-L285

You have to run "tox -e pre-commit" or you can fix it manually.
See https://github.com/graphql-python/graphene-sqlalchemy/blob/master/CONTRIBUTING.md

Cheers

@Forever-Young
Copy link
Contributor Author

Fixed. Github editor tends to add trailing spaces..

@jnak jnak merged commit 8ea2086 into graphql-python:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnak jnak jnak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Forever-Young @coveralls @jnak