Skip to content

[Regression Fix] Call custom resolve functions if provided #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

jnak
Copy link
Collaborator

@jnak jnak commented Aug 6, 2019

Fixes issue #234. The regression was introduced in 2.2.1.

Custom resolve_<field_name> functions were no longer call for fields auto-generated by SQLAlchemyObjectType. The issue was caused by a soon-to-be-documented feature that allows users to rename auto-generated fields (aka ORMField.model_attr).

@coveralls
Copy link

coveralls commented Aug 6, 2019

Coverage Status

Coverage increased (+0.03%) to 97.308% when pulling faddcf3 on jnak:default-resolver into c89cf80 on graphql-python:master.

Copy link

@dtamez dtamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@Nabellaleen Nabellaleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me ! Sorry for the delay :/

@jnak jnak merged commit a361c52 into graphql-python:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants