Remove @fetch and nextgen engine #2923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondonz
commented
Aug 16, 2022
| @@ -175,30 +172,4 @@ private CompletableFuture<ExecutionResult> executeOperation(ExecutionContext exe | |||
|
|
|||
| return result; | |||
| } | |||
|
|
|||
|
|
|||
| private GraphQLObjectType getOperationRootType(GraphQLSchema graphQLSchema, OperationDefinition operationDefinition) { | |||
There was a problem hiding this comment.
Moved this to a util, it's also used by the ExecutableNormalizedOperationFactory
dondonz
commented
Aug 16, 2022
| @@ -109,7 +109,7 @@ private ExecutableNormalizedOperation createNormalizedQueryImpl(GraphQLSchema gr | |||
| .normalizedVariables(normalizedVariableValues) | |||
| .build(); | |||
|
|
|||
| GraphQLObjectType rootType = Common.getOperationRootType(graphQLSchema, operationDefinition); | |||
There was a problem hiding this comment.
This was the only reference to nextgen outside of the nextgen files
dondonz
commented
Aug 16, 2022
| @@ -96,4 +103,29 @@ public static void replaceTypeReferences(GraphQLSchema schema) { | |||
| SchemaTraverser schemaTraverser = new SchemaTraverser(schemaElement -> schemaElement.getChildrenWithTypeReferences().getChildrenAsList()); | |||
| schemaTraverser.depthFirst(new GraphQLTypeResolvingVisitor(typeMap), roots); | |||
| } | |||
|
|
|||
| public static GraphQLObjectType getOperationRootType(GraphQLSchema graphQLSchema, OperationDefinition operationDefinition) { | |||
There was a problem hiding this comment.
Added util method here. Let me know if there's a better util to chuck this method into
bbakerman
approved these changes
Aug 16, 2022
|
Nice one |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the
@fetchdirective and the nextgen engine, both were deprecated some time ago.