Skip to content

Interface type can have non-empty interface lists #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2021

Conversation

KammererTob
Copy link
Contributor

@KammererTob KammererTob commented Feb 15, 2021

Checklist

  • Pull requests follows the contribution guide
  • New or modified functionality is covered by tests

Description

Since interfaces can now implement other interfaces the interfaces list of interfaces should not always be empty when creating the GraphQLInterfaceType in createInterfaceObject. The test-case failed before, but should be considered valid in my eyes.

Copy link
Collaborator

@oryan-block oryan-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to improve the test a bit.

oryan-block
oryan-block previously approved these changes Feb 16, 2021
@oryan-block
Copy link
Collaborator

oryan-block commented Mar 4, 2021

@KammererTob please rebase the branch. We've migrated all tests to kotlin so you can leave it out. I can recreate your test after that.

Oryan M added 2 commits March 5, 2021 12:47
# Conflicts:
#	src/test/groovy/graphql/kickstart/tools/SchemaParserSpec.groovy
@vojtapol vojtapol merged commit 7c0e22f into graphql-java-kickstart:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants