Treat array of non-null scalars as scalars #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fix for graphql-java-kickstart#240, and test for same issue. When array of non-nullable scalars is input, an error is thrown from Jackson ObjectMapper. The problem then was, NonNullType was ignored by MethodFieldResolver.isScalarType. Changes in graphql-java-kickstart#342 handles NonNullType but it doesn't handle NonNullType.type is ListType.
vojtapol
requested changes
Jan 25, 2020
| @@ -31,6 +31,7 @@ val schemaDefinition = """ | |||
| ## Private comment! | |||
| scalar UUID | |||
| scalar customScalarMap | |||
| scalar Upload | |||
There was a problem hiding this comment.
I believe some testing code was left behind in this PR.
There was a problem hiding this comment.
The line is related to issue. The scalar is used in 'echoFiles' mutation which is part of the test scenario.
There was a problem hiding this comment.
Let me know if there is anything needed.
|
@oliemansm and @vojtapol Thanks for taking time to review, and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for #240, and test for same issue.
When array of non-nullable scalars is input, an error is thrown from Jackson ObjectMapper. The problem then was, NonNullType was ignored by MethodFieldResolver.isScalarType. Changes in #342 handles NonNullType but it doesn't handle NonNullType.type is ListType.