Merge pull request #476 from ooga/not-add-pageinfo-definition

Prevent to add PageInfo definition if not needed

Author: vojtapol

src/main/kotlin/graphql/kickstart/tools/relay/RelayConnectionFactory.kt

@@ -6,12 +6,18 @@ import graphql.language.*
 class RelayConnectionFactory : TypeDefinitionFactory {
 
     override fun create(existing: MutableList<Definition<*>>): List<Definition<*>> {
+        val connectionDirectives = findConnectionDirectives(existing)
+        if (connectionDirectives.isEmpty()) {
+            // do not add Relay definitions unless needed
+            return emptyList()
+        }
+
         val definitions = mutableListOf<Definition<*>>()
         val definitionsByName = existing.filterIsInstance<TypeDefinition<*>>()
             .associateBy { it.name }
             .toMutableMap()
 
-        findConnectionDirectives(existing)
+        connectionDirectives
             .flatMap { createDefinitions(it) }
             .forEach {
                 if (!definitionsByName.containsKey(it.name)) {

src/test/kotlin/graphql/kickstart/tools/relay/RelayConnectionFactoryTest.kt

@@ -0,0 +1,20 @@
+package graphql.kickstart.tools.relay
+
+import graphql.language.Definition
+import org.junit.Assert.assertEquals
+import org.junit.Test
+
+class RelayConnectionFactoryTest {
+
+    @Test
+    fun `should not add new definition when no @connection directive`() {
+        // setup
+        val factory = RelayConnectionFactory()
+        val existing = mutableListOf<Definition<*>>()
+
+        val newDefinitions = factory.create(existing)
+
+        // expect
+        assertEquals(newDefinitions.size, 0)
+    }
+}