Skip to content

Commit fabdb3d

Browse files
author
Johan ROUVE
committed
Review changes
1 parent 4379cc0 commit fabdb3d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/main/kotlin/graphql/kickstart/tools/relay/RelayConnectionFactory.kt

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ class RelayConnectionFactory : TypeDefinitionFactory {
88
override fun create(existing: MutableList<Definition<*>>): List<Definition<*>> {
99
val connectionDirectives = findConnectionDirectives(existing)
1010
if (connectionDirectives.isEmpty()) {
11+
// do not add Relay definitions unless needed
1112
return emptyList()
1213
}
1314

src/test/kotlin/graphql/kickstart/tools/relay/RelayConnectionFactoryTest.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package graphql.kickstart.tools.relay
22

33
import graphql.language.Definition
4-
import org.junit.Assert
4+
import org.junit.Assert.assertEquals
55
import org.junit.Test
66

77
class RelayConnectionFactoryTest {
@@ -15,6 +15,6 @@ class RelayConnectionFactoryTest {
1515
val newDefinitions = factory.create(existing)
1616

1717
// expect
18-
Assert.assertEquals(newDefinitions.size, 0)
18+
assertEquals(newDefinitions.size, 0)
1919
}
2020
}

0 commit comments

Comments
 (0)