Optimize single & batch query response writers to reduce memory allocation overhead #292
Conversation
…ation overhead caused by the servlet.
…ation overhead caused by the servlet.
There was a problem hiding this comment.
JDK8 based tests are failing, can you take a look at that? Maybe you're using something not compatible with JDK8?
Can you also try to get >80% test coverage on your changes? I see you have added tests, but can't judge coverage, and unfortunately SonarCloud doesn't support PR analysis on external PRs yet.
Didn't realize 8, 11, 15 are jdk version numbers... Updated test to be backward compatible. PTAL. The new class has close to 100% coverage: |
|
Thanks a lot! |
Optimize single & batch query response writers to reduce memory allocation overhead caused by the servlet.
When large 10MiB+ responses are serialized, existing implementation performs significant amount of redundant string conversions and string concatenations. In my scenario overhead reached as much as 4GiB in extra RAM allocated.
This change replaces Json serialization into a String with Json serialization into byte array for both single and batch queries. In addition, it removes all string concatenations from batch response writer.