-
Notifications
You must be signed in to change notification settings - Fork 112
Added error logging and error messaging response when errors occur #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
f6d2665
5e07998
7f538f7
463fe45
29fc998
ef9d8f9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ public void accept(String request) { | |
SubscriptionCommand command = commandProvider.getByType(message.getType()); | ||
command.apply(session, message); | ||
} catch (JsonProcessingException e) { | ||
log.error("Cannot read subscription command '{}'", request, e); | ||
log.error("Cannot read subscription command '{}': {}", request, e); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you add the |
||
session.sendMessage(new OperationMessage(Type.GQL_CONNECTION_ERROR, null, e.getMessage())); | ||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ public void apply(SubscriptionSession session, OperationMessage message) { | |
connectionListeners.forEach(it -> it.onConnect(session, message)); | ||
session.sendMessage(new OperationMessage(Type.GQL_CONNECTION_ACK, message.getId(), null)); | ||
} catch (Throwable t) { | ||
log.error("Cannot initialize subscription command '{}': {}", message, t); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you add the |
||
session.sendMessage(new OperationMessage(Type.GQL_CONNECTION_ERROR, message.getId(), t.getMessage())); | ||
} | ||
} | ||
|
Uh oh!
There was an error while loading. Please reload this page.