writing content as bytes to avoid contentLength calculation problems #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes on
setContentLength
broke some spring-security functionality as spring-security recalculatescontent-length
whengetWriter().write(String)
is called to check if the response is completed.Therefore the session cookie will only be set after everything is over and the response was already sent back to the client.
Here's where this happens: OnCommittedResponseWrapper.java
I think that using the same byte array used to set the
content-length
is the most secure way to avoid problems like this.I also changed the test, but not sure if it was the correct approach.