Skip to content

Should override javax.servlet.GenericServlet.init() instead of javax.servlet.GenericServlet.init(ServletConfig) in AbstractGraphQLHttpServlet #175

Closed
@sammyhk

Description

@sammyhk

Should override javax.servlet.GenericServlet.init() instead javax.servlet.GenericServlet.init(ServletConfig) or at least overriding javax.servlet.GenericServlet.init(ServletConfig) should call super.init(ServletConfig) in AbstractGraphQLHttpServlet (

public void init(ServletConfig servletConfig) {
).

Now subclass of it cannot call getServletConfig()/ getServletName() due to missing of calling super.init(ServletConfig)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions