Skip to content

test: cleanup test sessions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 23, 2021
Merged

test: cleanup test sessions #1

merged 12 commits into from
Sep 23, 2021

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Sep 23, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2021
@tswast tswast added owlbot:run Add this label to trigger the Owlbot post processor. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 23, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2021
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2021
@tswast
Copy link
Collaborator Author

tswast commented Sep 23, 2021

Except for cover, tests are passing:

nox > Running session cover
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/cover
nox > python -m pip install coverage pytest-cov
nox > coverage report --show-missing --fail-under=100
Name                            Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------------
db_dtypes/__init__.py             105      2     36      0    99%   100, 160
db_dtypes/core.py                 101      0     34      0   100%
db_dtypes/pandas_backports.py      77      0     18      0   100%
db_dtypes/version.py                1      0      0      0   100%
tests/unit/test_dtypes.py         330      0     60      1    99%   565->568
---------------------------------------------------------------------------
TOTAL                             614      2    148      1    99%
Coverage failure: total of 100 is less than fail-under=100
nox > Command coverage report --show-missing --fail-under=100 failed with exit code 2
nox > Session cover failed.
nox > Ran multiple sessions:
nox > * lint: success
nox > * unit-3.6: success
nox > * unit-3.7: success
nox > * unit-3.8: success
nox > * unit-3.9: success
nox > * cover: failed

Re: cover, I think I need to copy over the constraints files from googleapis/python-bigquery#972

@tswast tswast changed the title test: disable system test session test: cleanup test sessions Sep 23, 2021
@tswast
Copy link
Collaborator Author

tswast commented Sep 23, 2021

Okay, now some tests are failing now that I added constraints for minimum pandas. Will need to investigate further.

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2021
@tswast tswast merged commit bc9f34d into main Sep 23, 2021
@tswast tswast deleted the disable-system-tests branch September 23, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant