Skip to content

Use "db" prefix for dtypes #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tswast opened this issue Oct 14, 2021 · 0 comments · Fixed by #32
Closed

Use "db" prefix for dtypes #31

tswast opened this issue Oct 14, 2021 · 0 comments · Fixed by #32
Assignees
@tswast
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tswast
Copy link
Collaborator

tswast commented Oct 14, 2021

When we do upstream this to panda (#30) I suspect there will be times when this package is still used alongside the new pandas.

For example, to support INTERVAL data type, I suspect we'll want to add it here first before moving it upstream. There is a DateOffset class we'll want to use, but I don't believe it's a full dtype.

Even if that's not the case, I don't want to cause conflicts if this package happens to be installed an imported somewhere.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Oct 14, 2021
@tswast tswast self-assigned this Oct 14, 2021
@tswast tswast added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 14, 2021
This was referenced Oct 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@tswast