Skip to content

tests.compliance.date.test_date_compliance.TestMethods: test_value_counts[data_missing-False] failed #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flaky-bot bot opened this issue Aug 12, 2023 · 1 comment · Fixed by #208
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Aug 12, 2023

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: 4087061
buildURL: Build Status, Sponge
status: failed

Test output
self = 
all_data = 
[NaT, datetime.date(2022, 1, 27)]
Length: 2, dtype: dbdate
dropna = False
@pytest.mark.parametrize("dropna", [True, False])
def test_value_counts(self, all_data, dropna):
    all_data = all_data[:10]
    if dropna:
        # Overridden from
        # https://github.com/pandas-dev/pandas/blob/main/pandas/tests/extension/base/methods.py
        # to avoid difference in dtypes.
        other = db_dtypes.DateArray(all_data[~all_data.isna()])
    else:
        other = all_data

    result = pandas.Series(all_data).value_counts(dropna=dropna).sort_index()
    expected = pandas.Series(other).value_counts(dropna=dropna).sort_index()
  self.assert_series_equal(result, expected)

E AttributeError: 'TestMethods' object has no attribute 'assert_series_equal'

tests/compliance/date/test_date_compliance.py:91: AttributeError

@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 12, 2023
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Aug 12, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Aug 17, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (4087061), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Aug 17, 2023
@chalmerlowe chalmerlowe added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Aug 17, 2023
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 31, 2023
Due to an upstream change in how a module was imported and referenced, we needed to update some of our compliance tests to match.

Fixes #200 🦕
Fixes #201 🦕
Fixes #202 🦕
Fixes #203 🦕
Fixes #204 🦕
Fixes #205 🦕
Fixes #206 🦕
Fixes #207 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant