Skip to content

bug: modifies latency due to flakybot issues #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2024
Merged

bug: modifies latency due to flakybot issues #781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b1a3a7
bug: modifies latency due to flakybot issues
chalmerlowe Jun 10, 2024
4ca47f3
Merge branch 'main' into latency-value
chalmerlowe Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pandas_gbq/gbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,11 +419,12 @@ def run_query(self, query, max_results=None, progress_bar_type=None, **kwargs):
# Having too small a timeout_ms results in individual
# API calls timing out before they can finish.
# ~300 milliseconds is rule of thumb for bare minimum
# latency from the BigQuery API.
minimum_latency = 400
# latency from the BigQuery API, however, 400 milliseconds
# produced too many issues with flakybot failures.
minimum_latency = 500
if timeout_ms < minimum_latency:
raise QueryTimeout(
f"Query timeout must be at least 400 milliseconds: timeout_ms equals {timeout_ms}."
f"Query timeout must be at least 500 milliseconds: timeout_ms equals {timeout_ms}."
)
else:
timeout_ms = None
Expand Down