Skip to content

fix: edit units for time in tests #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 16, 2023
Merged

fix: edit units for time in tests #655

Changes from 16 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
49279d9
fix: edit units for time in tests
chalmerlowe Jul 20, 2023
f6c5c3e
fix: updates timestamp precision for additional tests
chalmerlowe Jul 20, 2023
e16c409
fix: tweaking another time resolution
chalmerlowe Jul 20, 2023
e5e834e
fix: tweaking yet another time resolution
chalmerlowe Jul 20, 2023
c2c2334
trying out an option
chalmerlowe Aug 4, 2023
aad7a6d
minor syntax tweak, added comma
chalmerlowe Aug 4, 2023
12d8682
fix linting
chalmerlowe Aug 4, 2023
080044b
test addition of dtypes to results
chalmerlowe Aug 4, 2023
5988917
Update tests/system/test_gbq.py
chalmerlowe Aug 4, 2023
c17e304
Merge branch 'main' into fix-timestamp-precision
chalmerlowe Aug 4, 2023
0172ac3
Update tests/system/test_read_gbq.py
chalmerlowe Aug 4, 2023
fe025f7
add tests to dtypes dict
chalmerlowe Aug 7, 2023
e48d3c2
Update tests/system/test_read_gbq.py
chalmerlowe Aug 7, 2023
b60ce30
Update tests/system/test_gbq.py
chalmerlowe Aug 7, 2023
b009a68
try again
chalmerlowe Aug 8, 2023
6bb87d2
add version check and skipif on several tests
chalmerlowe Aug 11, 2023
cd2c261
Update tests/system/test_read_gbq.py
chalmerlowe Aug 11, 2023
6c631f7
blacken/lint the file
chalmerlowe Aug 15, 2023
affbe0e
Adds a skipif statement to an additional test
chalmerlowe Aug 15, 2023
1f5635c
blacken the code
chalmerlowe Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/system/test_read_gbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import collections
import datetime
import decimal
import packaging.version
import random

import db_dtypes
Expand Down Expand Up @@ -38,6 +39,7 @@ def writable_table(
bigquery_client.delete_table(full_table_id)


@pytest.mark.skipif(packaging.version.parse(pandas.__version__).release >= (2, 0), reason="")
@pytest.mark.parametrize(["use_bqstorage_api"], [(True,), (False,)])
@pytest.mark.parametrize(
["query", "expected", "use_bqstorage_apis"],
Expand Down Expand Up @@ -545,6 +547,7 @@ def writable_table(
def test_default_dtypes(
read_gbq, query, expected, use_bqstorage_apis, use_bqstorage_api
):

if use_bqstorage_api not in use_bqstorage_apis:
pytest.skip(f"use_bqstorage_api={use_bqstorage_api} not supported.")
# the parameter useQueryCache=False is used in the following function call
Expand All @@ -555,6 +558,7 @@ def test_default_dtypes(
configuration={"query": {"useQueryCache": False}},
)
pandas.testing.assert_frame_equal(result, expected)
assert False


@pytest.mark.parametrize(["use_bqstorage_api"], [(True,), (False,)])
Expand Down