Skip to content

test: prevents query cache reuse that seems to trigger dtypes test failure #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 2, 2022
Merged

test: prevents query cache reuse that seems to trigger dtypes test failure #557

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e14d553
fix: updates dataset path
chalmerlowe Aug 15, 2022
6b1f925
fix: avoid reusing cached results
chalmerlowe Aug 17, 2022
f0da5e7
chore: fixes linting errors
chalmerlowe Aug 18, 2022
a4460e8
chore: fixes more linting errors
chalmerlowe Aug 18, 2022
3440579
Merge branch 'main' into dtypes-test-failure
chalmerlowe Sep 1, 2022
a66ec8e
adds comment regarding use of specific parameter to avoid cache mismatch
chalmerlowe Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/system/test_read_gbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,11 @@ def test_default_dtypes(
):
if use_bqstorage_api not in use_bqstorage_apis:
pytest.skip(f"use_bqstorage_api={use_bqstorage_api} not supported.")
result = read_gbq(query, use_bqstorage_api=use_bqstorage_api)
result = read_gbq(
query,
use_bqstorage_api=use_bqstorage_api,
configuration={"query": {"useQueryCache": False}},
)
pandas.testing.assert_frame_equal(result, expected)


Expand Down
2 changes: 1 addition & 1 deletion tests/system/test_read_gbq_with_bqstorage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def test_large_results(random_dataset, method_under_test):
total_amount,
passenger_count,
trip_distance
FROM `bigquery-public-data.new_york_taxi_trips.tlc_green_trips_2014`
FROM `bigquery-public-data.new_york.tlc_green_trips_2014`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I know the pain behind this change 🚕

-- Select non-null rows for no-copy conversion from Arrow to pandas.
WHERE total_amount IS NOT NULL
AND passenger_count IS NOT NULL
Expand Down