Skip to content

to_gbq respects location argument properly #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

robertlacok
Copy link
Contributor

If dataset does not exist, it gets created in the correct location

Fixes issue 213: #213

Copy link

@stickler-ci stickler-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following files do not match the black styleguide:

  • pandas_gbq/gbq.py
  • tests/system/test_gbq.py

@robertlacok robertlacok force-pushed the dataset-creation-respects-location branch from 0a1e91c to 8addac5 Compare October 4, 2018 16:31
Copy link

@stickler-ci stickler-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following files do not match the black styleguide:

  • tests/system/test_gbq.py

If dataset does not exist, it gets created in the correct location
@robertlacok robertlacok force-pushed the dataset-creation-respects-location branch from 8addac5 to 410a0b8 Compare October 4, 2018 16:33
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit 942c879 into googleapis:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants