Skip to content

TST: add mocked job_id for google-cloud-bigquery 0.29 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 25, 2018

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 24, 2018

Closes #168.

@tswast tswast requested a review from max-sixty April 24, 2018 20:47
@max-sixty
Copy link
Contributor

I'm not sure how this could cause E ImportError: No module named pandas?
https://travis-ci.org/pydata/pandas-gbq/jobs/370804286

@tswast
Copy link
Collaborator Author

tswast commented Apr 24, 2018

I think the remaining failure is a regression of conda/conda#5483 in how Conda handles namespace packages.

@tswast
Copy link
Collaborator Author

tswast commented Apr 25, 2018

Sigh. Conda builds are still failing. I've tried removing everything that could be a bad interaction with conda and pip, but still no luck.

I think it really could be a regression in conda. To check that, I think the next step is to change

wget http://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh -O miniconda.sh;

to a pinned version. If that fixes it, we should file a bug against conda.

@tswast
Copy link
Collaborator Author

tswast commented Apr 25, 2018

I have no idea what's going on. Maybe there is something subtle about one of the newer versions of google-cloud-biquery that breaks on Conda? I guess we could try pinning that package.

@tswast
Copy link
Collaborator Author

tswast commented Apr 25, 2018

The command "if [[ $PYTHON == '3.6' ]] && [[ "$PANDAS" == "MASTER" ]]; then nox -s test36master ; fi" exited with 0.
1.33s$ REQ="ci/requirements-${PYTHON}-${PANDAS}" ; if [ -f "$REQ.conda" ]; then pytest -v tests ; fi
============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.5.1, py-1.5.3, pluggy-0.6.0 -- /home/travis/miniconda/envs/test-environment/bin/python
cachedir: .pytest_cache
rootdir: /home/travis/build/pydata/pandas-gbq, inifile:
plugins: cov-2.5.1
collecting ... collected 29 items / 2 errors
==================================== ERRORS ====================================
___________________ ERROR collecting tests/unit/test_load.py ___________________
ImportError while importing test module '/home/travis/build/pydata/pandas-gbq/tests/unit/test_load.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/unit/test_load.py:6: in <module>
    from pandas_gbq import load
pandas_gbq/load.py:4: in <module>
    from google.cloud import bigquery
../../../miniconda/envs/test-environment/lib/python3.6/site-packages/google_cloud_bigquery-1.1.0-py3.6.egg/google/cloud/bigquery/__init__.py:34: in <module>
    from google.cloud.bigquery._helpers import DEFAULT_RETRY
../../../miniconda/envs/test-environment/lib/python3.6/site-packages/google_cloud_bigquery-1.1.0-py3.6.egg/google/cloud/bigquery/_helpers.py:20: in <module>
    from google.api_core import retry
E   ModuleNotFoundError: No module named 'google.api_core'
__________________ ERROR collecting tests/unit/test_query.py ___________________
ImportError while importing test module '/home/travis/build/pydata/pandas-gbq/tests/unit/test_query.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/unit/test_query.py:9: in <module>
    from pandas_gbq import query
pandas_gbq/query.py:3: in <module>
    from google.cloud import bigquery
../../../miniconda/envs/test-environment/lib/python3.6/site-packages/google_cloud_bigquery-1.1.0-py3.6.egg/google/cloud/bigquery/__init__.py:34: in <module>
    from google.cloud.bigquery._helpers import DEFAULT_RETRY
../../../miniconda/envs/test-environment/lib/python3.6/site-packages/google_cloud_bigquery-1.1.0-py3.6.egg/google/cloud/bigquery/_helpers.py:20: in <module>
    from google.api_core import retry
E   ModuleNotFoundError: No module named 'google.api_core'
!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 2 error in 0.64 seconds ============================

@tswast
Copy link
Collaborator Author

tswast commented Apr 25, 2018

Whew, pinning google-cloud-bigquery fixed the conda build. I'll merge this so master gets green again.

I filed conda-forge/google-cloud-bigquery-feedstock#10 to track it, but not sure when I can get to it to investigate further.

@tswast tswast merged commit 187a57f into master Apr 25, 2018
@tswast tswast deleted the issue-168-master branch April 25, 2018 03:48
@max-sixty
Copy link
Contributor

Thanks a lot @tswast !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants