TST: use nox for testing #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Apr 6, 2018
nox.py
Outdated
| import nox | ||
|
|
||
|
|
||
| PANDAS_PRE_WHEELS='https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com' |
There was a problem hiding this comment.
E501 line too long (103 > 79 characters)
stickler-ci
reviewed
Apr 6, 2018
nox.py
Outdated
| import nox | ||
|
|
||
|
|
||
| PANDAS_PRE_WHEELS = 'https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com' |
There was a problem hiding this comment.
E501 line too long (103 > 79 characters)
The reason is that nox isn't playing nice with conda. "Could not find _remove_dead_weakref"
tswast
force-pushed
the
mock
branch
2 times, most recently
from
029b1f2 to
81306a7
Compare
|
@maxim-lian I think I finally fixed the busted tests. 😤 https://travis-ci.org/pydata/pandas-gbq/builds/363360912 Full integration tests still running at https://travis-ci.org/tswast/pandas-gbq/builds/363360902 I think the issue before was that there is some conflict between installing packages via pip and installing packages via conda. Somehow a bad version of the The new setup uses |
This was referenced Apr 7, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't actually reproduce the test failures introduced in #158 locally. My hope is that by using
nox(liketox, but configurable via Python code) the more isolated environments will fix whatever error with mocks we're getting.A step towards #52.