project_id as optional

.gitignore

@@ -20,7 +20,8 @@
 .ipynb_checkpoints
 .tags
 .pytest_cache
-.testmondata
+.testmon*
+.vscode/
 
 # Docs #
 ########

.travis.yml

@@ -3,10 +3,10 @@ sudo: false
 language: python
 
 env:
-  - PYTHON=2.7 PANDAS=0.19.2 COVERAGE='false' LINT='true'
-  - PYTHON=3.5 PANDAS=0.18.1 COVERAGE='true' LINT='false'
-  - PYTHON=3.6 PANDAS=0.20.1 COVERAGE='false' LINT='false'
-  - PYTHON=3.6 PANDAS=MASTER COVERAGE='false' LINT='true'
+  - PYTHON=2.7 PANDAS=0.19.2 COVERAGE='false' LINT='true' AUTH='s_path'
+  - PYTHON=3.5 PANDAS=0.18.1 COVERAGE='true' LINT='false' AUTH='s_path'
+  - PYTHON=3.6 PANDAS=0.20.1 COVERAGE='false' LINT='false' AUTH='s_cred'
+  - PYTHON=3.6 PANDAS=MASTER COVERAGE='false' LINT='true' AUTH='s_cred'
 
 before_install:
   - echo "before_install"
@@ -42,6 +42,7 @@ install:
   - python setup.py install
 
 script:
-  - pytest -v --cov=pandas_gbq --cov-report xml:/tmp/pytest-cov.xml pandas_gbq
+  - if [[ $AUTH == 's_path' ]]; then pytest -m 'not local_auth and not s_cred_auth' -v --cov=pandas_gbq --cov-report xml:/tmp/pytest-cov.xml pandas_gbq  ; fi
+  - if [[ $AUTH == 's_cred' ]]; then pytest -m 'not local_auth and not s_path_auth' -v --cov=pandas_gbq --cov-report xml:/tmp/pytest-cov.xml pandas_gbq  ; fi
   - if [[ $COVERAGE == 'true' ]]; then codecov ; fi
   - if [[ $LINT == 'true' ]]; then flake8 pandas_gbq -v ; fi

pandas_gbq/gbq.py

@@ -170,6 +170,9 @@ def __init__(self, project_id, reauth=False,
         from google.api_core.exceptions import GoogleAPIError
         from google.api_core.exceptions import ClientError
         self.http_error = (ClientError, GoogleAPIError)
+        if not project_id:
+            from google.auth import default
+            _, project_id = default()
         self.project_id = project_id
         self.reauth = reauth
         self.private_key = private_key
@@ -752,7 +755,7 @@ def read_gbq(query, project_id=None, index_col=None, col_order=None,
     ----------
     query : str
         SQL-Like Query to return data values
-    project_id : str
+    project_id : str (optional when available in environment)
         Google BigQuery Account project ID.
     index_col : str (optional)
         Name of result column to use for index in results DataFrame
@@ -810,9 +813,6 @@ def read_gbq(query, project_id=None, index_col=None, col_order=None,
 
     _test_google_api_imports()
 
-    if not project_id:
-        raise TypeError("Missing required parameter: project_id")
-
     if dialect not in ('legacy', 'standard'):
         raise ValueError("'{0}' is not valid for dialect".format(dialect))
 
@@ -860,7 +860,7 @@ def read_gbq(query, project_id=None, index_col=None, col_order=None,
     return final_df
 
 
-def to_gbq(dataframe, destination_table, project_id, chunksize=None,
+def to_gbq(dataframe, destination_table, project_id=None, chunksize=None,
            verbose=None, reauth=False, if_exists='fail', private_key=None,
            auth_local_webserver=False, table_schema=None):
     """Write a DataFrame to a Google BigQuery table.
@@ -892,7 +892,7 @@ def to_gbq(dataframe, destination_table, project_id, chunksize=None,
         DataFrame to be written
     destination_table : string
         Name of table to be written, in the form 'dataset.tablename'
-    project_id : str
+    project_id : str (optional when available in environment)
         Google BigQuery Account project ID.
     chunksize : int (default None)
         Number of rows to be inserted in each chunk from the dataframe. Use

pandas_gbq/tests/test_gbq.py

@@ -25,11 +25,6 @@
 TABLE_ID = 'new_test'
 
 
-def _skip_local_auth_if_in_travis_env():
-    if _in_travis_environment():
-        pytest.skip("Cannot run local auth in travis environment")
-
-
 def _skip_if_no_private_key_path():
     if not _get_private_key_path():
         pytest.skip("Cannot run integration tests without a "
@@ -52,12 +47,8 @@ def _get_dataset_prefix_random():
 
 
 def _get_project_id():
-
-    project = os.environ.get('GBQ_PROJECT_ID')
-    if not project:
-        pytest.skip(
-            "Cannot run integration tests without a project id")
-    return project
+    return (os.environ.get('GBQ_PROJECT_ID')
+            or os.environ.get('GOOGLE_CLOUD_PROJECT'))  # noqa
 
 
 def _get_private_key_path():
@@ -87,9 +78,12 @@ def _test_imports():
     gbq._test_google_api_imports()
 
 
-@pytest.fixture
-def project():
-    return _get_project_id()
+@pytest.fixture(params=['env'])
+def project(request):
+    if request.param == 'env':
+        return _get_project_id()
+    elif request.param == 'none':
+        return None
 
 
 def _check_if_can_get_correct_default_credentials():
@@ -101,11 +95,13 @@ def _check_if_can_get_correct_default_credentials():
     from google.auth.exceptions import DefaultCredentialsError
 
     try:
-        credentials, _ = google.auth.default(scopes=[gbq.GbqConnector.scope])
+        credentials, project = google.auth.default(
+            scopes=[gbq.GbqConnector.scope])
     except (DefaultCredentialsError, IOError):
         return False
 
-    return gbq._try_credentials(_get_project_id(), credentials) is not None
+    return gbq._try_credentials(
+        project or _get_project_id(), credentials) is not None
 
 
 def clean_gbq_environment(dataset_prefix, private_key=None):
@@ -173,21 +169,18 @@ def test_generate_bq_schema_deprecated():
         gbq.generate_bq_schema(df)
 
 
-@pytest.fixture(params=['local', 'service_path', 'service_creds'])
+@pytest.fixture(params=[
+    pytest.param('local', marks=pytest.mark.local_auth),
+    pytest.param('service_path', marks=pytest.mark.s_path_auth),
+    pytest.param('service_creds', marks=pytest.mark.s_cred_auth),
+])
 def auth_type(request):
 
     auth = request.param
 
     if auth == 'local':
-
-        if _in_travis_environment():
-            pytest.skip("Cannot run local auth in travis environment")
-
+        pass
     elif auth == 'service_path':
-
-        if _in_travis_environment():
-            pytest.skip("Only run one auth type in Travis to save time")
-
         _skip_if_no_private_key_path()
     elif auth == 'service_creds':
         _skip_if_no_private_key_contents()
@@ -238,13 +231,12 @@ def test_should_be_able_to_get_results_from_query(self, gbq_connector):
         assert pages is not None
 
 
+@pytest.mark.local_auth
 class TestGBQConnectorIntegrationWithLocalUserAccountAuth(object):
 
     @pytest.fixture(autouse=True)
     def setup(self, project):
 
-        _skip_local_auth_if_in_travis_env()
-
         self.sut = gbq.GbqConnector(project, auth_local_webserver=True)
 
     def test_get_application_default_credentials_does_not_throw_error(self):
@@ -310,12 +302,8 @@ def test_to_gbq_should_fail_if_invalid_table_name_passed(self):
         with pytest.raises(gbq.NotFoundException):
             gbq.to_gbq(DataFrame(), 'invalid_table_name', project_id="1234")
 
-    def test_to_gbq_with_no_project_id_given_should_fail(self):
-        with pytest.raises(TypeError):
-            gbq.to_gbq(DataFrame(), 'dataset.tablename')
-
-    def test_read_gbq_with_no_project_id_given_should_fail(self):
-        with pytest.raises(TypeError):
+    def test_read_gbq_with_no_project_id_given_should_pass(self, credentials):
+        if _check_if_can_get_correct_default_credentials():
             gbq.read_gbq('SELECT 1')
 
     def test_that_parse_data_works_properly(self):