Skip to content

Commit fbd2665

Browse files
committed
Reapply "UPDATE_KOTLIN_VERSION: 1.9.30-dev-2548"
This reverts commit ea7e9d2.
1 parent 3ae3c6e commit fbd2665

File tree

2 files changed

+17
-16
lines changed

2 files changed

+17
-16
lines changed

gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KotlinFactories.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ import org.gradle.process.CommandLineArgumentProvider
3939
import org.gradle.process.ExecOperations
4040
import org.gradle.work.InputChanges
4141
import org.gradle.workers.WorkerExecutor
42+
import org.jetbrains.kotlin.buildtools.api.SourcesChanges
4243
import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
4344
import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
4445
import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
@@ -67,7 +68,6 @@ import org.jetbrains.kotlin.gradle.tasks.TaskOutputsBackup
6768
import org.jetbrains.kotlin.gradle.tasks.configuration.BaseKotlin2JsCompileConfig
6869
import org.jetbrains.kotlin.gradle.tasks.configuration.KotlinCompileCommonConfig
6970
import org.jetbrains.kotlin.gradle.tasks.configuration.KotlinCompileConfig
70-
import org.jetbrains.kotlin.incremental.ChangedFiles
7171
import org.jetbrains.kotlin.konan.target.HostManager
7272
import java.io.File
7373
import java.nio.file.Paths
@@ -186,7 +186,7 @@ interface KspTask : Task {
186186
val commandLineArgumentProviders: ListProperty<CommandLineArgumentProvider>
187187

188188
@get:Internal
189-
val incrementalChangesTransformers: ListProperty<(ChangedFiles) -> List<SubpluginOption>>
189+
val incrementalChangesTransformers: ListProperty<(SourcesChanges) -> List<SubpluginOption>>
190190
}
191191

192192
@CacheableTask

gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspSubplugin.kt

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import org.gradle.tooling.provider.model.ToolingModelBuilderRegistry
3636
import org.gradle.util.GradleVersion
3737
import org.gradle.work.ChangeType
3838
import org.gradle.work.InputChanges
39+
import org.jetbrains.kotlin.buildtools.api.SourcesChanges
3940
import org.jetbrains.kotlin.config.ApiVersion
4041
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
4142
import org.jetbrains.kotlin.gradle.internal.kapt.incremental.CLASS_STRUCTURE_ARTIFACT_TYPE
@@ -56,7 +57,6 @@ import org.jetbrains.kotlin.gradle.plugin.SubpluginOption
5657
import org.jetbrains.kotlin.gradle.plugin.getKotlinPluginVersion
5758
import org.jetbrains.kotlin.gradle.plugin.mpp.*
5859
import org.jetbrains.kotlin.gradle.tasks.*
59-
import org.jetbrains.kotlin.incremental.ChangedFiles
6060
import org.jetbrains.kotlin.incremental.isJavaFile
6161
import org.jetbrains.kotlin.incremental.isKotlinFile
6262
import org.jetbrains.kotlin.utils.addToStdlib.ifNotEmpty
@@ -664,15 +664,16 @@ internal fun getClassStructureFiles(
664664
// Reuse Kapt's infrastructure to compute affected names in classpath.
665665
// This is adapted from KaptTask.findClasspathChanges.
666666
internal fun findClasspathChanges(
667-
changes: ChangedFiles,
667+
changes: SourcesChanges,
668668
cacheDir: File,
669669
allDataFiles: Set<File>,
670670
libs: List<File>,
671671
processorCP: List<File>,
672672
): KaptClasspathChanges {
673673
cacheDir.mkdirs()
674674

675-
val changedFiles = (changes as? ChangedFiles.Known)?.let { it.modified + it.removed }?.toSet() ?: allDataFiles
675+
val changedFiles =
676+
(changes as? SourcesChanges.Known)?.let { it.modifiedFiles + it.removedFiles }?.toSet() ?: allDataFiles
676677

677678
val loadedPrevious = ClasspathSnapshot.ClasspathSnapshotFactory.loadFrom(cacheDir)
678679
val previousAndCurrentDataFiles = lazy { loadedPrevious.getAllDataFiles() + allDataFiles }
@@ -701,7 +702,7 @@ internal fun findClasspathChanges(
701702
)
702703

703704
val classpathChanges = currentSnapshot.diff(previousSnapshot, changedFiles)
704-
if (classpathChanges is KaptClasspathChanges.Unknown || changes is ChangedFiles.Unknown) {
705+
if (classpathChanges is KaptClasspathChanges.Unknown || changes is SourcesChanges.Unknown) {
705706
cacheDir.deleteRecursively()
706707
cacheDir.mkdirs()
707708
}
@@ -710,11 +711,11 @@ internal fun findClasspathChanges(
710711
return classpathChanges
711712
}
712713

713-
internal fun ChangedFiles.hasNonSourceChange(): Boolean {
714-
if (this !is ChangedFiles.Known)
714+
internal fun SourcesChanges.hasNonSourceChange(): Boolean {
715+
if (this !is SourcesChanges.Known)
715716
return true
716717

717-
return !(this.modified + this.removed).all {
718+
return !(this.modifiedFiles + this.removedFiles).all {
718719
it.isKotlinFile(listOf("kt")) || it.isJavaFile()
719720
}
720721
}
@@ -729,13 +730,13 @@ fun KaptClasspathChanges.toSubpluginOptions(): List<SubpluginOption> {
729730
}
730731
}
731732

732-
fun ChangedFiles.toSubpluginOptions(): List<SubpluginOption> {
733-
return if (this is ChangedFiles.Known) {
733+
fun SourcesChanges.toSubpluginOptions(): List<SubpluginOption> {
734+
return if (this is SourcesChanges.Known) {
734735
val options = mutableListOf<SubpluginOption>()
735-
this.modified.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
736+
this.modifiedFiles.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
736737
options += SubpluginOption("knownModified", map { it.path }.joinToString(File.pathSeparator))
737738
}
738-
this.removed.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
739+
this.removedFiles.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
739740
options += SubpluginOption("knownRemoved", map { it.path }.joinToString(File.pathSeparator))
740741
}
741742
options
@@ -752,7 +753,7 @@ internal fun createIncrementalChangesTransformer(
752753
classpathStructure: Provider<FileCollection>,
753754
libraries: Provider<FileCollection>,
754755
processorCP: Provider<FileCollection>,
755-
): (ChangedFiles) -> List<SubpluginOption> = { changedFiles ->
756+
): (SourcesChanges) -> List<SubpluginOption> = { changedFiles ->
756757
val options = mutableListOf<SubpluginOption>()
757758
val apClasspath = processorCP.get().files.toList()
758759
if (isKspIncremental) {
@@ -793,7 +794,7 @@ internal fun getCPChanges(
793794
): List<String> {
794795
val apClasspath = processorCP.files.toList()
795796
val changedFiles = if (!inputChanges.isIncremental) {
796-
ChangedFiles.Unknown()
797+
SourcesChanges.Unknown
797798
} else {
798799
incrementalProps.fold(mutableListOf<File>() to mutableListOf<File>()) { (modified, removed), prop ->
799800
inputChanges.getFileChanges(prop).forEach {
@@ -805,7 +806,7 @@ internal fun getCPChanges(
805806
}
806807
modified to removed
807808
}.run {
808-
ChangedFiles.Known(first, second)
809+
SourcesChanges.Known(first, second)
809810
}
810811
}
811812
val classpathChanges = findClasspathChanges(

0 commit comments

Comments
 (0)