Skip to content

Commit ea7e9d2

Browse files
ting-yuanneetopia
authored andcommitted
Revert "UPDATE_KOTLIN_VERSION: 1.9.30-dev-2548"
This reverts commit aa9b0ef. (cherry picked from commit ac186ab) (cherry picked from commit 44a949f)
1 parent a2b9298 commit ea7e9d2

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KotlinFactories.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ import org.gradle.process.CommandLineArgumentProvider
3939
import org.gradle.process.ExecOperations
4040
import org.gradle.work.InputChanges
4141
import org.gradle.workers.WorkerExecutor
42-
import org.jetbrains.kotlin.buildtools.api.SourcesChanges
4342
import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
4443
import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
4544
import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
@@ -68,6 +67,7 @@ import org.jetbrains.kotlin.gradle.tasks.TaskOutputsBackup
6867
import org.jetbrains.kotlin.gradle.tasks.configuration.BaseKotlin2JsCompileConfig
6968
import org.jetbrains.kotlin.gradle.tasks.configuration.KotlinCompileCommonConfig
7069
import org.jetbrains.kotlin.gradle.tasks.configuration.KotlinCompileConfig
70+
import org.jetbrains.kotlin.incremental.ChangedFiles
7171
import org.jetbrains.kotlin.konan.target.HostManager
7272
import java.io.File
7373
import java.nio.file.Paths
@@ -186,7 +186,7 @@ interface KspTask : Task {
186186
val commandLineArgumentProviders: ListProperty<CommandLineArgumentProvider>
187187

188188
@get:Internal
189-
val incrementalChangesTransformers: ListProperty<(SourcesChanges) -> List<SubpluginOption>>
189+
val incrementalChangesTransformers: ListProperty<(ChangedFiles) -> List<SubpluginOption>>
190190
}
191191

192192
@CacheableTask

gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspSubplugin.kt

+14-15
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import org.gradle.tooling.provider.model.ToolingModelBuilderRegistry
3636
import org.gradle.util.GradleVersion
3737
import org.gradle.work.ChangeType
3838
import org.gradle.work.InputChanges
39-
import org.jetbrains.kotlin.buildtools.api.SourcesChanges
4039
import org.jetbrains.kotlin.config.ApiVersion
4140
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
4241
import org.jetbrains.kotlin.gradle.internal.kapt.incremental.CLASS_STRUCTURE_ARTIFACT_TYPE
@@ -57,6 +56,7 @@ import org.jetbrains.kotlin.gradle.plugin.SubpluginOption
5756
import org.jetbrains.kotlin.gradle.plugin.getKotlinPluginVersion
5857
import org.jetbrains.kotlin.gradle.plugin.mpp.*
5958
import org.jetbrains.kotlin.gradle.tasks.*
59+
import org.jetbrains.kotlin.incremental.ChangedFiles
6060
import org.jetbrains.kotlin.incremental.isJavaFile
6161
import org.jetbrains.kotlin.incremental.isKotlinFile
6262
import org.jetbrains.kotlin.utils.addToStdlib.ifNotEmpty
@@ -664,16 +664,15 @@ internal fun getClassStructureFiles(
664664
// Reuse Kapt's infrastructure to compute affected names in classpath.
665665
// This is adapted from KaptTask.findClasspathChanges.
666666
internal fun findClasspathChanges(
667-
changes: SourcesChanges,
667+
changes: ChangedFiles,
668668
cacheDir: File,
669669
allDataFiles: Set<File>,
670670
libs: List<File>,
671671
processorCP: List<File>,
672672
): KaptClasspathChanges {
673673
cacheDir.mkdirs()
674674

675-
val changedFiles =
676-
(changes as? SourcesChanges.Known)?.let { it.modifiedFiles + it.removedFiles }?.toSet() ?: allDataFiles
675+
val changedFiles = (changes as? ChangedFiles.Known)?.let { it.modified + it.removed }?.toSet() ?: allDataFiles
677676

678677
val loadedPrevious = ClasspathSnapshot.ClasspathSnapshotFactory.loadFrom(cacheDir)
679678
val previousAndCurrentDataFiles = lazy { loadedPrevious.getAllDataFiles() + allDataFiles }
@@ -702,7 +701,7 @@ internal fun findClasspathChanges(
702701
)
703702

704703
val classpathChanges = currentSnapshot.diff(previousSnapshot, changedFiles)
705-
if (classpathChanges is KaptClasspathChanges.Unknown || changes is SourcesChanges.Unknown) {
704+
if (classpathChanges is KaptClasspathChanges.Unknown || changes is ChangedFiles.Unknown) {
706705
cacheDir.deleteRecursively()
707706
cacheDir.mkdirs()
708707
}
@@ -711,11 +710,11 @@ internal fun findClasspathChanges(
711710
return classpathChanges
712711
}
713712

714-
internal fun SourcesChanges.hasNonSourceChange(): Boolean {
715-
if (this !is SourcesChanges.Known)
713+
internal fun ChangedFiles.hasNonSourceChange(): Boolean {
714+
if (this !is ChangedFiles.Known)
716715
return true
717716

718-
return !(this.modifiedFiles + this.removedFiles).all {
717+
return !(this.modified + this.removed).all {
719718
it.isKotlinFile(listOf("kt")) || it.isJavaFile()
720719
}
721720
}
@@ -730,13 +729,13 @@ fun KaptClasspathChanges.toSubpluginOptions(): List<SubpluginOption> {
730729
}
731730
}
732731

733-
fun SourcesChanges.toSubpluginOptions(): List<SubpluginOption> {
734-
return if (this is SourcesChanges.Known) {
732+
fun ChangedFiles.toSubpluginOptions(): List<SubpluginOption> {
733+
return if (this is ChangedFiles.Known) {
735734
val options = mutableListOf<SubpluginOption>()
736-
this.modifiedFiles.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
735+
this.modified.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
737736
options += SubpluginOption("knownModified", map { it.path }.joinToString(File.pathSeparator))
738737
}
739-
this.removedFiles.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
738+
this.removed.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
740739
options += SubpluginOption("knownRemoved", map { it.path }.joinToString(File.pathSeparator))
741740
}
742741
options
@@ -753,7 +752,7 @@ internal fun createIncrementalChangesTransformer(
753752
classpathStructure: Provider<FileCollection>,
754753
libraries: Provider<FileCollection>,
755754
processorCP: Provider<FileCollection>,
756-
): (SourcesChanges) -> List<SubpluginOption> = { changedFiles ->
755+
): (ChangedFiles) -> List<SubpluginOption> = { changedFiles ->
757756
val options = mutableListOf<SubpluginOption>()
758757
val apClasspath = processorCP.get().files.toList()
759758
if (isKspIncremental) {
@@ -794,7 +793,7 @@ internal fun getCPChanges(
794793
): List<String> {
795794
val apClasspath = processorCP.files.toList()
796795
val changedFiles = if (!inputChanges.isIncremental) {
797-
SourcesChanges.Unknown
796+
ChangedFiles.Unknown()
798797
} else {
799798
incrementalProps.fold(mutableListOf<File>() to mutableListOf<File>()) { (modified, removed), prop ->
800799
inputChanges.getFileChanges(prop).forEach {
@@ -806,7 +805,7 @@ internal fun getCPChanges(
806805
}
807806
modified to removed
808807
}.run {
809-
SourcesChanges.Known(first, second)
808+
ChangedFiles.Known(first, second)
810809
}
811810
}
812811
val classpathChanges = findClasspathChanges(

0 commit comments

Comments
 (0)