Skip to content

Commit ac186ab

Browse files
committed
Revert "UPDATE_KOTLIN_VERSION: 1.9.30-dev-2548"
This reverts commit aa9b0ef.
1 parent b1fefb3 commit ac186ab

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KotlinFactories.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ import org.gradle.process.CommandLineArgumentProvider
3939
import org.gradle.process.ExecOperations
4040
import org.gradle.work.InputChanges
4141
import org.gradle.workers.WorkerExecutor
42-
import org.jetbrains.kotlin.buildtools.api.SourcesChanges
4342
import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
4443
import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
4544
import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
@@ -68,6 +67,7 @@ import org.jetbrains.kotlin.gradle.tasks.TaskOutputsBackup
6867
import org.jetbrains.kotlin.gradle.tasks.configuration.BaseKotlin2JsCompileConfig
6968
import org.jetbrains.kotlin.gradle.tasks.configuration.KotlinCompileCommonConfig
7069
import org.jetbrains.kotlin.gradle.tasks.configuration.KotlinCompileConfig
70+
import org.jetbrains.kotlin.incremental.ChangedFiles
7171
import org.jetbrains.kotlin.konan.target.HostManager
7272
import java.io.File
7373
import java.nio.file.Paths
@@ -186,7 +186,7 @@ interface KspTask : Task {
186186
val commandLineArgumentProviders: ListProperty<CommandLineArgumentProvider>
187187

188188
@get:Internal
189-
val incrementalChangesTransformers: ListProperty<(SourcesChanges) -> List<SubpluginOption>>
189+
val incrementalChangesTransformers: ListProperty<(ChangedFiles) -> List<SubpluginOption>>
190190
}
191191

192192
@CacheableTask

gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspSubplugin.kt

+14-15
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import org.gradle.tooling.provider.model.ToolingModelBuilderRegistry
3636
import org.gradle.util.GradleVersion
3737
import org.gradle.work.ChangeType
3838
import org.gradle.work.InputChanges
39-
import org.jetbrains.kotlin.buildtools.api.SourcesChanges
4039
import org.jetbrains.kotlin.config.ApiVersion
4140
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
4241
import org.jetbrains.kotlin.gradle.internal.kapt.incremental.CLASS_STRUCTURE_ARTIFACT_TYPE
@@ -57,6 +56,7 @@ import org.jetbrains.kotlin.gradle.plugin.SubpluginOption
5756
import org.jetbrains.kotlin.gradle.plugin.getKotlinPluginVersion
5857
import org.jetbrains.kotlin.gradle.plugin.mpp.*
5958
import org.jetbrains.kotlin.gradle.tasks.*
59+
import org.jetbrains.kotlin.incremental.ChangedFiles
6060
import org.jetbrains.kotlin.incremental.isJavaFile
6161
import org.jetbrains.kotlin.incremental.isKotlinFile
6262
import org.jetbrains.kotlin.utils.addToStdlib.ifNotEmpty
@@ -661,16 +661,15 @@ internal fun getClassStructureFiles(
661661
// Reuse Kapt's infrastructure to compute affected names in classpath.
662662
// This is adapted from KaptTask.findClasspathChanges.
663663
internal fun findClasspathChanges(
664-
changes: SourcesChanges,
664+
changes: ChangedFiles,
665665
cacheDir: File,
666666
allDataFiles: Set<File>,
667667
libs: List<File>,
668668
processorCP: List<File>,
669669
): KaptClasspathChanges {
670670
cacheDir.mkdirs()
671671

672-
val changedFiles =
673-
(changes as? SourcesChanges.Known)?.let { it.modifiedFiles + it.removedFiles }?.toSet() ?: allDataFiles
672+
val changedFiles = (changes as? ChangedFiles.Known)?.let { it.modified + it.removed }?.toSet() ?: allDataFiles
674673

675674
val loadedPrevious = ClasspathSnapshot.ClasspathSnapshotFactory.loadFrom(cacheDir)
676675
val previousAndCurrentDataFiles = lazy { loadedPrevious.getAllDataFiles() + allDataFiles }
@@ -699,7 +698,7 @@ internal fun findClasspathChanges(
699698
)
700699

701700
val classpathChanges = currentSnapshot.diff(previousSnapshot, changedFiles)
702-
if (classpathChanges is KaptClasspathChanges.Unknown || changes is SourcesChanges.Unknown) {
701+
if (classpathChanges is KaptClasspathChanges.Unknown || changes is ChangedFiles.Unknown) {
703702
cacheDir.deleteRecursively()
704703
cacheDir.mkdirs()
705704
}
@@ -708,11 +707,11 @@ internal fun findClasspathChanges(
708707
return classpathChanges
709708
}
710709

711-
internal fun SourcesChanges.hasNonSourceChange(): Boolean {
712-
if (this !is SourcesChanges.Known)
710+
internal fun ChangedFiles.hasNonSourceChange(): Boolean {
711+
if (this !is ChangedFiles.Known)
713712
return true
714713

715-
return !(this.modifiedFiles + this.removedFiles).all {
714+
return !(this.modified + this.removed).all {
716715
it.isKotlinFile(listOf("kt")) || it.isJavaFile()
717716
}
718717
}
@@ -727,13 +726,13 @@ fun KaptClasspathChanges.toSubpluginOptions(): List<SubpluginOption> {
727726
}
728727
}
729728

730-
fun SourcesChanges.toSubpluginOptions(): List<SubpluginOption> {
731-
return if (this is SourcesChanges.Known) {
729+
fun ChangedFiles.toSubpluginOptions(): List<SubpluginOption> {
730+
return if (this is ChangedFiles.Known) {
732731
val options = mutableListOf<SubpluginOption>()
733-
this.modifiedFiles.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
732+
this.modified.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
734733
options += SubpluginOption("knownModified", map { it.path }.joinToString(File.pathSeparator))
735734
}
736-
this.removedFiles.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
735+
this.removed.filter { it.isKotlinFile(listOf("kt")) || it.isJavaFile() }.ifNotEmpty {
737736
options += SubpluginOption("knownRemoved", map { it.path }.joinToString(File.pathSeparator))
738737
}
739738
options
@@ -750,7 +749,7 @@ internal fun createIncrementalChangesTransformer(
750749
classpathStructure: Provider<FileCollection>,
751750
libraries: Provider<FileCollection>,
752751
processorCP: Provider<FileCollection>,
753-
): (SourcesChanges) -> List<SubpluginOption> = { changedFiles ->
752+
): (ChangedFiles) -> List<SubpluginOption> = { changedFiles ->
754753
val options = mutableListOf<SubpluginOption>()
755754
val apClasspath = processorCP.get().files.toList()
756755
if (isKspIncremental) {
@@ -791,7 +790,7 @@ internal fun getCPChanges(
791790
): List<String> {
792791
val apClasspath = processorCP.files.toList()
793792
val changedFiles = if (!inputChanges.isIncremental) {
794-
SourcesChanges.Unknown
793+
ChangedFiles.Unknown()
795794
} else {
796795
incrementalProps.fold(mutableListOf<File>() to mutableListOf<File>()) { (modified, removed), prop ->
797796
inputChanges.getFileChanges(prop).forEach {
@@ -803,7 +802,7 @@ internal fun getCPChanges(
803802
}
804803
modified to removed
805804
}.run {
806-
SourcesChanges.Known(first, second)
805+
ChangedFiles.Known(first, second)
807806
}
808807
}
809808
val classpathChanges = findClasspathChanges(

0 commit comments

Comments
 (0)