Fix treatment of nested messages by TypeNames::JsExpression. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, the parent type would be returned. Now, <parent type>.<child type> is returned.
reddaly
added a commit
to gonzojive/rules_ts_proto
that referenced
this pull request
Mar 13, 2023
Incorporates changes to protobuf-javascript library from gonzojive/protobuf-javascript#3.
gonzojive
pushed a commit
to gonzojive/rules_ts_proto
that referenced
this pull request
Mar 13, 2023
Incorporates changes to protobuf-javascript library from gonzojive/protobuf-javascript#3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, the parent type would be returned. Now, . is returned.
Due to our limited support resources, we are focusing our attention on small bug fixes that have limited compatibility concerns. Most other PRs will be rejected.