Added go-mnd linter #842
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package golinters | ||
|
|
||
| import ( | ||
| magic_numbers "github.com/tommy-muehle/go-mnd" | ||
|
There was a problem hiding this comment. Nit: I would just alias this as |
||
| "golang.org/x/tools/go/analysis" | ||
|
|
||
| "github.com/golangci/golangci-lint/pkg/golinters/goanalysis" | ||
| ) | ||
|
|
||
| func NewGomnd() *goanalysis.Linter { | ||
|
There was a problem hiding this comment. Nit: Similarly, I would name this |
||
| analyzers := []*analysis.Analyzer{ | ||
| magic_numbers.Analyzer, | ||
| } | ||
|
|
||
| return goanalysis.NewLinter( | ||
| "gomnd", | ||
| "checks whether magic number is used", | ||
| analyzers, | ||
| nil, | ||
| ).WithLoadMode(goanalysis.LoadModeSyntax) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| //args: -Egomnd | ||
| package testdata | ||
|
|
||
| import ( | ||
| "log" | ||
| "net/http" | ||
| "time" | ||
| ) | ||
|
|
||
| func UseMagicNumber() { | ||
| c := &http.Client{ | ||
| Timeout: 1 * time.Second, // ERROR : "Magic number: 1, in <assign> detected" | ||
| } | ||
|
|
||
| res, err := c.Get("http://www.google.com") | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| if res.StatusCode != 200 { // ERROR : "Magic number: 200, in <condition> detected" | ||
| log.Println("Something went wrong") | ||
| } | ||
| } | ||
|
|
||
| func UseNoMagicNumber() { | ||
| c := &http.Client{ | ||
| Timeout: time.Second, | ||
| } | ||
|
|
||
| res, err := c.Get("http://www.google.com") | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| if res.StatusCode != http.StatusOK { | ||
| log.Println("Something went wrong") | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to reference a tagged release version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried before, but it gives me the below error (even the tag is available)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I got it now, the tag in github.com/tommy-muehle/go-mnd is not prefixed with
v, so we can only use pseudo-versions onlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raised one issue here tommy-muehle/go-mnd#1