Skip to content

Drop memory usage of go/analysis linters 5x #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2019
Merged

Drop memory usage of go/analysis linters 5x #725

merged 1 commit into from
Sep 23, 2019

Conversation

jirfag
Copy link
Contributor

@jirfag jirfag commented Sep 23, 2019

Set analysis pass results to nil early to garbage collect them
soon.
Memory can be reduced for the following linters:

  • staticcheck
  • stylecheck
  • gosimple
  • govet
  • bodyclose
  • any future go/analysis linter

Relates: #712, #634, #628, #598, #509, #483, #337

@jirfag
Drop memory usage of go/analysis linters 5x
96ab61b 
Set analysis pass results to nil early to garbage collect them
soon.
Memory can be reduced for the following linters:
  - staticcheck
  - stylecheck
  - gosimple
  - govet
  - bodyclose
  - any future go/analysis linter

Relates: #712, #634, #628, #598, #509, #483, #337
@tpounds
Copy link
Contributor

tpounds commented Sep 23, 2019

LGTM 🚢 it!

@jirfag jirfag merged commit 2fc8b7b into master Sep 23, 2019
@jirfag jirfag deleted the feature/drop-memory-usage-more branch September 23, 2019 18:58
@bmhatfield bmhatfield mentioned this pull request Sep 24, 2019
Closed
@ldez ldez added this to the v1.19 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpounds tpounds tpounds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@jirfag @tpounds @ldez