Skip to content

Bump goconst to v1.8.0 #5707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kalexmills
Copy link

@kalexmills kalexmills commented Apr 9, 2025

I realized too late that I can't expect this PR to be merged unless I am the author of the linter. Alas, the work is done.

In any case, we made some changes upstream to release v1.8.0 and goconst now uses the typechecker as a result. I'll open an issue downstream to alert the linter author.

goconst now finds duplicate constants and can evaluate constant expressions in some cases.

Copy link

boring-cyborg bot commented Apr 9, 2025

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2025

CLA assistant check
All committers have signed the CLA.

@ldez ldez closed this Apr 9, 2025
@ldez
Copy link
Member

ldez commented Apr 9, 2025

The rules are the rules, sorry.

@ldez ldez added the declined label Apr 9, 2025
@ldez
Copy link
Member

ldez commented Apr 9, 2025

It's useless to open an issue on the goconst repo, as the PR template says: the dependabot handles the updates.

@kalexmills
Copy link
Author

kalexmills commented Apr 9, 2025

@ldez thanks for the quick response. We added features in v1.8.0 which will require integration support to use, that's mainly what this PR handles.

In any case, I've opened an issue upstream and pointed the linter author to this PR.

@ldez
Copy link
Member

ldez commented Apr 9, 2025

I will explain the reason for this rule: it takes more time to review a PR than do the modifications.
Also, the Dependabot uses a specific commit format and PR description with useful information for the update.

So, even for authors of linters, in most cases, I prefer to handle that with Dependabot.

#5709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants