Skip to content

fix: gocritic importshadow checker #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 1, 2025

Fixes #5672

@ldez ldez added bug Something isn't working linter: update Update the linter implementation inside golangci-lint labels Apr 1, 2025
@ldez ldez added this to the v2-unreleased milestone Apr 1, 2025
@ldez ldez force-pushed the feat/gocritic-importshadow branch 2 times, most recently from 9a8ac22 to 4eaa72a Compare April 1, 2025 06:46
@ldez ldez force-pushed the feat/gocritic-importshadow branch from 4eaa72a to 7c37d1f Compare April 1, 2025 06:47
@ldez ldez requested a review from bombsimon April 1, 2025 06:48
@ldez ldez requested a review from alexandear April 1, 2025 11:29
@ldez ldez merged commit db2214f into golangci:main Apr 1, 2025
19 checks passed
@ldez ldez deleted the feat/gocritic-importshadow branch April 1, 2025 11:43
@ldez ldez modified the milestones: v2-unreleased, v2.1 Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gocritic: importShadow rule doesn't appear to work
2 participants