Skip to content

chore: enable linters.exclusions.warn-unused #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alexandear
Copy link
Member

We can remove some exclusions:

$ golangci-lint run
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "test/testdata_etc", Linters: "gofmt, goimports"] 
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "internal/x", Linters: "gofmt, goimports"] 
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "pkg/commands/internal/migrate/two/", Linters: "lll"] 
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "internal/go", Linters: "gofmt, goimports"] 
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "pkg/goformatters/gci/internal", Linters: "gofmt, goimports"] 
WARN [runner/exclusion_rules] Skipped 0 issues by rules: [Path: "pkg/goanalysis/runner_checker.go", Linters: "gofmt, goimports"] 
0 issues.

@ldez ldez closed this Mar 31, 2025
@ldez ldez added the declined label Mar 31, 2025
@ldez
Copy link
Member

ldez commented Mar 31, 2025

I didn't enable this option because it has side effects on the tests.

Also, the current exclusions should be kept because this is related to borrowed code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants