Skip to content

dev: ask about installation inside issue template #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 16, 2025

I think it is interesting to know how users install golangci-lint.

@ldez ldez added the topic: cosmetic changes contain cosmetic improvements label Feb 16, 2025
@ldez ldez added this to the unreleased milestone Feb 16, 2025
@ldez ldez requested review from alexandear and bombsimon February 16, 2025 21:53
@ccoVeille
Copy link
Contributor

Nit: typo with "installation" (being written instalation) in commit message and PR title

@alexandear alexandear changed the title dev: ask about instalation inside issue template dev: ask about installation inside issue template Feb 17, 2025
@ldez ldez requested a review from alexandear February 17, 2025 13:08
@ldez ldez merged commit a8b68a5 into golangci:master Feb 17, 2025
18 checks passed
@ldez ldez deleted the feat/issue-templates branch February 17, 2025 13:33
- type: dropdown
id: install
attributes:
label: How did you install golangci-lint?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow why this would be relevant when doing a feature request?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see that as a way to get information about our users.

But in some cases, this is important: we have issues related to usage that we don't want to promote (like using golangci-lint as a lib).

id: install
attributes:
label: How did you install golangci-lint?
options:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's not common enough for people to run the VS Code or IntelliJ/GoLand plugin (or some vim plugin such as Mason) that it should be part of this? Either an option like "Via my editor/IDE" or the most common ones like IntelliJ and VS Code.

alexandear pushed a commit to alexandear-org/golangci-lint that referenced this pull request Feb 18, 2025
@ldez ldez modified the milestones: unreleased, v1.64 Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cosmetic changes contain cosmetic improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants