Skip to content

dev: use bool pointer on deprecated bool options #5254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Dec 25, 2024

Replaces bool by bool pointer to detect explicit false or true inside the configuration.

linters-settings:
  copyloopvar:
    ignore-alias: false
  govet:
    check-shadowing: false
  usestdlibvars:
    os-dev-null: false
    syslog-priority: false
  unused:
    exported-is-used: false

issues:
  exclude-generated-strict: false

output:
  uniq-by-line: false

run:
  show-stats: false
  skip-dirs-use-default: false
$ golangci-lint run
WARN [config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`. 
WARN [config_reader] The configuration option `run.show-stats` is deprecated, please use `output.show-stats` 
WARN [config_reader] The configuration option `output.uniq-by-line` is deprecated, please use `issues.uniq-by-line` 
WARN [config_reader] The configuration option `issues.exclude-generated-strict` is deprecated, please use `issues.exclude-generated` 
WARN [config_reader] The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`. 
WARN [config_reader] The configuration option `linters.copyloopvar.ignore-alias` is deprecated and ignored,please use `linters.copyloopvar.check-alias`. 
WARN [config_reader] The configuration option `linters.unused.exported-is-used` is deprecated. 
WARN [config_reader] The configuration option `linters.usestdlibvars.os-dev-null` is deprecated. 
WARN [config_reader] The configuration option `linters.usestdlibvars.syslog-priority` is deprecated. 

@ldez ldez added area: config Related to .golangci.yml and/or cli options topic: cleanup Related to code, process, or doc cleanup labels Dec 25, 2024
@ldez ldez added this to the next milestone Dec 25, 2024
@ldez ldez changed the title dev: use bool pointer on deprecated options dev: use bool pointer on deprecated bool options Dec 25, 2024
@ldez ldez merged commit 24b51ea into golangci:master Dec 26, 2024
15 checks passed
@ldez ldez deleted the fix/use-pointer-bool-deprecated branch December 26, 2024 16:23
@ldez ldez modified the milestones: next, v1.63 Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: config Related to .golangci.yml and/or cli options topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants