Skip to content

fix(tenv): disable for Go versions < 1.17 #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

scop
Copy link
Contributor

@scop scop commented Dec 25, 2024

No description provided.

@ldez ldez added the declined label Dec 25, 2024
@ldez
Copy link
Member

ldez commented Dec 25, 2024

We don't support Go versions lower than go1.22 (with a slight tolerance for go1.21).

https://golangci-lint.run/welcome/faq/#which-go-versions-are-supported

@ldez ldez closed this Dec 25, 2024
@ldez ldez deleted the fix/tenv-117 branch December 25, 2024 18:22
@ccoVeille
Copy link
Contributor

We don't support Go versions lower than go1.22 (with a slight tolerance for go1.21).

https://golangci-lint.run/welcome/faq/#which-go-versions-are-supported

I have a suggestion. Maybe I'm wrong and it's already the case but:

Maybe the app could simply report an error message then, maybe return an exitcode when lower than 1.21.

Because I mean it's not supported, but it can be launched, so people expect things.

But maybe it's too extreme and a breaking changes.

But it's not that uncommon to see people reporting about blah blah version older than x, and you close "but x is not supported"

I don't have a computer to check what it does and reports now, also I'm always migrating to latest Go version.

@ldez
Copy link
Member

ldez commented Dec 25, 2024

For me, this is useless: t.Env doesn't compile before go1.17 (go1.17 is from 2021).
Golangci-lint can be used for the old Go versions, we will not limit that artificially.
I prefer to have a "wrong" report that forces users to use the supported Go version (by the Go team).

And this is an edge case, as you said: there are literally no reports about this kind of problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants