Skip to content

dev: refactor linter constructors for consistency #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

dev: refactor linter constructors for consistency #5173

merged 1 commit into from
Nov 29, 2024

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Nov 29, 2024 •
edited by ldez
Loading

Refactor linters constructors:

  • rename parameters setting, s, and cfg to settings
  • rename variables cfgMap, linterCfg to cfg.
$ grep -r "func New(settings \*config\." --include \*.go | wc -l
      70
$ grep -r "func New(cfg \*config\." --include \*.go | wc -l
       8

@ldez ldez changed the title refactor linter constructors for consistency dev: refactor linter constructors for consistency Nov 29, 2024
@ldez ldez added the topic: cosmetic changes contain cosmetic improvements label Nov 29, 2024
@ldez ldez added this to the next milestone Nov 29, 2024
@ldez ldez merged commit 9921355 into golangci:master Nov 29, 2024
15 checks passed
@alexandear alexandear deleted the dev-rename-linters-new-param branch November 29, 2024 22:01
@ldez ldez modified the milestones: next, v1.63 Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
topic: cosmetic changes contain cosmetic improvements
Projects
None yet
Milestone
v1.63
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ldez