Skip to content

docs: fix links to gocritic checks #5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandear
Copy link
Member

This PR fixes links for gocritic checks and replaces https://go-critic.github.io with https://go-critic.com.

E.g. the link "https://go-critic.com/overview.html#badSyncOnceFunc" is wrong, must be "https://go-critic.com/overview.html#badsynconcefunc".

@ldez ldez added topic: cosmetic changes contain cosmetic improvements bug Something isn't working and removed topic: cosmetic changes contain cosmetic improvements labels Nov 11, 2024
@ldez ldez added this to the next milestone Nov 11, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 7930491 into golangci:master Nov 11, 2024
15 checks passed
@alexandear alexandear deleted the docs/fix-gocritic-links-to-checks branch November 11, 2024 15:00
@ldez ldez modified the milestones: next, v1.62 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants