Skip to content

dev: remove Nancy #5047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2024
Merged

dev: remove Nancy #5047

merged 1 commit into from
Sep 29, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 27, 2024

As we are using dependabot, Nancy (which focuses on dependency vulnerabilities) is not required anymore.

@ldez ldez added enhancement New feature or improvement area: ci PR that update CI labels Sep 27, 2024
@ldez ldez added this to the next milestone Sep 27, 2024
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used Nancy so don't know about the overlap but if dependabot alerts about vulnerabilities even when no new version is available this sounds reasonable.

@ldez
Copy link
Member Author

ldez commented Sep 29, 2024

In fact, Nancy never reported something useful, mainly because dependabot handles the dependency updates.

But Nancy has reported a lot of false positives, as you can see inside the .nancy-ignore, which breaks the CI on PRs.

@ldez ldez merged commit 8659611 into golangci:master Sep 29, 2024
15 checks passed
@ldez ldez deleted the fix/remove-nancy branch September 29, 2024 18:39
@ldez ldez modified the milestones: next, v1.62 Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci PR that update CI enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants