Skip to content

dev: avoid panic in processors #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

dev: avoid panic in processors #4777

wants to merge 1 commit into from

Conversation

alexandear
Copy link
Member

Refactor code by removing panic calls in processors.

@alexandear alexandear added the topic: cleanup Related to code, process, or doc cleanup label May 30, 2024
@ldez
Copy link
Member

ldez commented May 30, 2024 •
edited
Loading

Those cases cannot happen this is why there is a panic and not an error.

@ldez ldez self-requested a review May 30, 2024 13:14
@alexandear
Copy link
Member Author

alexandear commented May 30, 2024 •
edited
Loading

Those cases cannot happen this is why there is a panic and not an error.

Okay.

Should I remove the unused root field from the PathPrettifier in this PR?

@ldez ldez added the declined label May 30, 2024
@ldez ldez closed this May 30, 2024
@ldez
Copy link
Member

ldez commented May 30, 2024

You can create a dedicated PR to clean the PathPrettifier construction.

@alexandear alexandear deleted the dev-avoid-panic-in-processors branch May 30, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez Awaiting requested review from ldez

Assignees
No one assigned
Labels
area: processors declined topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ldez