Skip to content

docs: fix typos #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2024
Merged

docs: fix typos #4763

merged 4 commits into from
May 27, 2024

Conversation

ccoVeille
Copy link
Contributor

@ccoVeille ccoVeille commented May 27, 2024 •
edited by ldez
Loading

  • chore: fix typo
  • chore: fix registered trademarks
  • chore: fix acronyms case
  • chore: fix style

ccoVeille added 4 commits May 28, 2024 01:10
@ccoVeille
chore: fix typo
f42333b 
bellow: roar
below: under
@ccoVeille
chore: fix registered trademarks
e4c1cf3 
- Alpine Linux
- Bash
- CLA
- GitHub
- GitHub Action
- Homebrew
- macOS
- MacPorts
- Markdown
- Powershell
- Zsh

All these brands have a specific exact way to write them
@ccoVeille
chore: fix acronyms case
62a1c54 
acronyms should be in uppercase
@ccoVeille
chore: fix style
f0234de 
add missing commas
@CLAassistant
Copy link

CLAassistant commented May 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title typos suggestion docs: typos suggestion May 27, 2024
@ldez ldez added area: docs topic: cosmetic changes contain cosmetic improvements labels May 27, 2024
@ccoVeille
Copy link
Contributor Author

I split PR in multiple commits to make things clearer, and allow me to prune/edit any commit you would like me to update/nuke

Feel free to squash them later

@ldez ldez added this to the next milestone May 27, 2024
@ldez
Copy link
Member

ldez commented May 27, 2024 •
edited
Loading

FYI, during a review, the changes should be addressed as commits to ease the review.
You should never "edit" an existing commit to address reviews.

The PRs are always squashed during the merge of the PR, not inside the PR, to keep the history of the changes.

@ccoVeille
Copy link
Contributor Author

ccoVeille commented May 27, 2024 •
edited by ldez
Loading

OK, noted

ldez
ldez approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title docs: typos suggestion docs: fix typos May 27, 2024
@ldez ldez merged commit dea416b into golangci:master May 27, 2024
13 checks passed
@ccoVeille ccoVeille deleted the typos-suggestion branch May 28, 2024 00:02
@ldez ldez modified the milestones: next, v1.59 Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: docs topic: cosmetic changes contain cosmetic improvements
Projects
None yet
Milestone
v1.59
Development

Successfully merging this pull request may close these issues.
3 participants
@ccoVeille @CLAassistant @ldez