Skip to content

chore: fix typo with errchkjson in linters info #4762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: fix typo with errchkjson in linters info #4762

wants to merge 1 commit into from

Conversation

ccoVeille
Copy link
Contributor

This typo was fixed ages ago on errchkjson repository

breml/errchkjson@04c8758

This typo was fixed ages ago on errchkjson repository

breml/errchkjson@04c8758
Copy link

boring-cyborg bot commented May 27, 2024

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented May 27, 2024

CLA assistant check
All committers have signed the CLA.

@ldez
Copy link
Member

ldez commented May 27, 2024

This file is generated from the analyzer description.

https://github.com/breml/errchkjson/blob/8dad78889977f675ad8338a5c9ed6d14f5bffcfc/errchkjson.go#L28

The analyzer should be edited.

@ccoVeille
Copy link
Contributor Author

Indeed, I will open a PR there then. I didn't see the file was autogenerated.

@ldez
Copy link
Member

ldez commented May 27, 2024

JSON format doesn't allow comments, so it's difficult to flag the file as generated.

@ccoVeille
Copy link
Contributor Author

JSON format doesn't allow comments, so it's difficult to flag the file as generated.

I understood it after posting my comment.

@ccoVeille
Copy link
Contributor Author

Indeed, I will open a PR there then.

breml/errchkjson#44

@ccoVeille
Copy link
Contributor Author

feel free to close this PR if there is no need for it once breml/errchkjson#44 would be merged

@ldez
Copy link
Member

ldez commented May 27, 2024

FYI, the file is only generated post-release, so we can exceptionally merge this PR.

But if we create a release before the release of errchkjson the typo will be reverted.

@ldez ldez added this to the next milestone May 27, 2024
@ldez ldez closed this May 27, 2024
@ldez ldez added the declined label May 27, 2024
@ldez ldez removed this from the next milestone May 27, 2024
@ccoVeille ccoVeille deleted the fix-typo-errchkjson branch May 27, 2024 23:33
@ccoVeille
Copy link
Contributor Author

FYI, the file is only generated post-release, so we can exceptionally merge this PR.

But if we create a release before the release of errchkjson the typo will be reverted.

Thanks for the explanations and context

breml/errchkjson#44 was merged

I understand it would be fixed somehow in golangci-lint in a matter of weeks/month

I'm unsure if my fix only would imply a release. And it's not a big issue I raised.

So we will see. Thanks again

@ldez
Copy link
Member

ldez commented May 28, 2024

I'm unsure if my fix only would imply a release.

To be usable inside golangci-lint, errchkjson should create a release.

@ccoVeille
Copy link
Contributor Author

Yes, my point was more. I have understood it may happen now or later. I'm OK with it. I have understood the process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants