-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: fix typo with errchkjson in linters info #4762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This typo was fixed ages ago on errchkjson repository breml/errchkjson@04c8758
Hey, thank you for opening your first Pull Request ! |
This file is generated from the analyzer description. The analyzer should be edited. |
Indeed, I will open a PR there then. I didn't see the file was autogenerated. |
JSON format doesn't allow comments, so it's difficult to flag the file as generated. |
I understood it after posting my comment. |
|
feel free to close this PR if there is no need for it once breml/errchkjson#44 would be merged |
FYI, the file is only generated post-release, so we can exceptionally merge this PR. But if we create a release before the release of errchkjson the typo will be reverted. |
Thanks for the explanations and context breml/errchkjson#44 was merged I understand it would be fixed somehow in golangci-lint in a matter of weeks/month I'm unsure if my fix only would imply a release. And it's not a big issue I raised. So we will see. Thanks again |
To be usable inside golangci-lint, errchkjson should create a release. |
Yes, my point was more. I have understood it may happen now or later. I'm OK with it. I have understood the process |
This typo was fixed ages ago on errchkjson repository
breml/errchkjson@04c8758