-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Support Sarif output #4723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ldez
merged 7 commits into
golangci:master
from
SophisticaSean:sophisticasean/support-sarif-output
May 19, 2024
Merged
Support Sarif output #4723
ldez
merged 7 commits into
golangci:master
from
SophisticaSean:sophisticasean/support-sarif-output
May 19, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey, thank you for opening your first Pull Request ! |
alexandear
reviewed
May 17, 2024
Co-authored-by: Oleksandr Redko <[email protected]>
Wow thanks so much for the quick fixes and reviews. Y'all are impressive! |
ldez
approved these changes
May 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @SophisticaSean and all the reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work supports exporting Sarif file format. It's a common enough format and I figured I'd help out by adding it. :)
Sarif documentation:
https://github.com/microsoft/sarif-tutorials/blob/main/docs/2-Basics.md#results
https://docs.oasis-open.org/sarif/sarif/v2.1.0/cs01/schemas/sarif-external-property-file-schema-2.1.0.json
fixes #2866