Skip to content

dev: deprecate errcheck.ignore option #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented May 8, 2024

The PR marks errcheck.ignore lint option as deprecated. See #332 and https://github.com/kisielk/errcheck#the-deprecated-method.

Related to #4673

@alexandear alexandear force-pushed the feat/errcheck-ignore-deprecated branch from 6a786c9 to f104e17 Compare May 8, 2024 19:53
@alexandear alexandear added topic: cleanup Related to code, process, or doc cleanup area: config Related to .golangci.yml and/or cli options labels May 8, 2024
@ldez ldez added this to the next milestone May 8, 2024
@ldez ldez self-requested a review May 8, 2024 20:04
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 565c81f into golangci:master May 8, 2024
13 checks passed
@alexandear alexandear deleted the feat/errcheck-ignore-deprecated branch May 9, 2024 08:25
@ldez ldez modified the milestones: next, v1.58 May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: config Related to .golangci.yml and/or cli options topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants