Skip to content

dev: fix shellcheck lint issues #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

alexandear
Copy link
Member

This PR fixes shellcheck linter issues:

The function log_prefix() is removed because it's redefined below.

Details
❯ shellcheck install.sh

In install.sh line 154:
  echo "$0"
  ^-------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).


In install.sh line 203:
    sunos) [ $(uname -o) == "illumos" ] && os=illumos ;;
             ^---------^ SC2046 (warning): Quote this to prevent word splitting.
                         ^-- SC3014 (warning): In POSIX sh, == in place of = is undefined.


In install.sh line 221:
  echo ${arch}
       ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  echo "${arch}"

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC3014 -- In POSIX sh, == in place of = is ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

@alexandear alexandear added the topic: cleanup Related to code, process, or doc cleanup label Apr 18, 2024
@ldez ldez merged commit d681d93 into golangci:master Apr 18, 2024
13 checks passed
@alexandear alexandear deleted the fix/shellcheck-issues branch April 18, 2024 14:34
@ldez ldez added this to the next milestone Apr 20, 2024
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants