Skip to content

dev: eliminate redundant indentation #4650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Apr 16, 2024

revive is already included in .golangci.yaml. This PR only enables one revive's rule:

Updated 1 path from the index
❯ golangci-lint run
pkg/lint/lintersdb/builder_plugin_go.go:51:10: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
                } else {
                        linters = append(linters, lc)
                }

@alexandear alexandear added topic: cosmetic changes contain cosmetic improvements topic: cleanup Related to code, process, or doc cleanup and removed topic: cosmetic changes contain cosmetic improvements labels Apr 16, 2024
@ldez ldez added this to the next milestone Apr 16, 2024
@ldez ldez merged commit b09bd6e into golangci:master Apr 16, 2024
13 checks passed
@alexandear alexandear deleted the fix-indent-error-flow branch April 16, 2024 14:49
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants