Skip to content

fix: JSON schema about severities #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: JSON schema about severities #4617

merged 1 commit into from
Apr 5, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 5, 2024

Fixes #4616

@ldez ldez added bug Something isn't working area: JSON schema labels Apr 5, 2024
@ldez ldez added this to the next milestone Apr 5, 2024
@ldez ldez force-pushed the fix/severity-jsonschema branch from 08c704d to 1432a08 Compare April 5, 2024 16:27
ryancurrah
ryancurrah approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@ryancurrah ryancurrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works locally. I tested with this VSCode config.

    "yaml.schemas": {
        "https://raw.githubusercontent.com/ldez/golangci-lint/fix/severity-jsonschema/jsonschema/golangci.jsonschema.json": ".golangci.yml"
    },

@ldez ldez merged commit a706941 into golangci:master Apr 5, 2024
13 checks passed
@ldez ldez deleted the fix/severity-jsonschema branch April 5, 2024 16:41
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryancurrah ryancurrah ryancurrah approved these changes

Assignees
No one assigned
Labels
area: JSON schema bug Something isn't working
Projects
None yet
Milestone
v1.58
Development

Successfully merging this pull request may close these issues.

schema validation errors in issues.severity that should be valid
2 participants
@ldez @ryancurrah