Skip to content

dev: set timeout for loading JSON schema #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

alexandear
Copy link
Member

jsonschema uses the default HTTP client for loading JSON schemas, which doesn't have request timeouts. This PR overrides the global HTTP client from the library with a client that includes a timeout.

@alexandear alexandear added the area: config Related to .golangci.yml and/or cli options label Apr 1, 2024
@alexandear alexandear force-pushed the feat/config-verify-timeout branch from c14960a to ed0088a Compare April 1, 2024 17:23
@ldez ldez added area: CLI Related to CLI area: JSON schema and removed area: config Related to .golangci.yml and/or cli options labels Apr 1, 2024
@ldez ldez added this to the next milestone Apr 1, 2024
@ldez ldez self-requested a review April 1, 2024 17:24
@ldez ldez merged commit 1ff07c1 into golangci:master Apr 1, 2024
13 checks passed
@alexandear alexandear deleted the feat/config-verify-timeout branch April 1, 2024 17:46
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants