Skip to content

dev: enable testifylint linter #4595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

alexandear
Copy link
Member

The PR enables testifylint for this repo.

golangci-lint run
pkg/golinters/misspell_test.go:32:2: expected-actual: need to reverse actual and expected values (testifylint)
        assert.Equal(t, replacer.Replacements, expected)
        ^
pkg/result/processors/autogenerated_exclude_test.go:255:4: require-error: for error assertions use require (testifylint)
                        assert.EqualError(t, err, test.expected)
                        ^
pkg/result/processors/skip_files_test.go:52:2: require-error: for error assertions use require (testifylint)
        assert.Error(t, err)
        ^

@alexandear alexandear added the topic: cleanup Related to code, process, or doc cleanup label Mar 29, 2024
@ldez ldez merged commit ec97551 into golangci:master Mar 29, 2024
13 checks passed
@ldez ldez added this to the next milestone Mar 29, 2024
@alexandear alexandear deleted the dev-enable-testifylint branch April 11, 2024 14:52
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants